[MERGE] bundle commandline cleanup

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Aaron Bentley wrote:
>>>>> ^- So why are you always pulling from 'last_revision()' rather than the
>>>>> base revision that was specified? Potentially they are not even the same
>>>>> ancestry.
> 
> Okay, I've had a closer look at the code.  The scenario you describe
> can't happen, because the purpose of that codepath is to determine the
> base revision when the user hasn't specified one.  If the user has
> specified a base, we won't hit that codepath.
> 
> In pseudocode:
> 
> if no_base_specified:
>     base_revision = common_ancestor(base_branch.last_revision(),
>                                     target_revision)
> 
> So I don't think that needs fixing.
> 
> Aaron

Looking back, I think you are right. Just hard to tell from the diff.
So the only thing is the url_for_display stuff. And +1 from me.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEo/POJdeBCYSNAAMRAnSDAJ9wsOOfC4JjxrSNnv+EHsnLOluF6QCbB8Qx
7HWksDfAq9nWsAvSsdXmmys=
=Oway
-----END PGP SIGNATURE-----