[MERGE] bundle commandline cleanup

John Arbash Meinel john at arbash-meinel.com
Thu Jun 29 16:33:48 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>>> That makes sense.
>>> The problem is that 'note()' has never been defined as to what its
>>> encoding is.
> 
> I think note should be unicode.  If it's encoded, it should always use
> errors='replace', because it's secondary output, so failures shouldn't
> prevent the command from running to completion.
> 
> Aaron

Well, url_for_display tries to be nice, and if it can't display the
output, it leaves it as url encoded.
So there is still some benefit to knowing the final output encoding.
Otherwise you would get an invalid url (with ?) rather than getting
something that doesn't look as nice, but is still valid.

Otherwise I would agree that note() should be a Unicode api.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEo/LbJdeBCYSNAAMRApfNAJ9hCB8ERGuJN8TxxHJJG0YZfCHdZACeNNP0
jrMAuAAyPE/Z8TMwBh7FgFk=
=q8YR
-----END PGP SIGNATURE-----




More information about the bazaar mailing list