cdv test failures
james.henstridge at gmail.com
Fri May 26 07:09:52 BST 2006
On 26/05/06, John Arbash Meinel <john at arbash-meinel.com> wrote:
> Martin Pool wrote:
> > Is it even possible to override something called __helper? I would have
> > thought mangling meant it always called the original implementation.
> > +1 for this patch. One comment - since you're overriding it, perhaps
> > you should use a better name than __helper -- even just
> > _find_matching_blocks.
> I was surprised to see it work as well. But it definitely did. I always
> thought that with the mangling the parent would always call its own
It worked because both difflib.SequenceMatcher and
bzrlib.patiencediff.SequenceMatcher rewrote __helper to
_SequenceMatcher__helper(). If the classes had different names, it
would not have worked.
More information about the bazaar