cdv test failures

Andrew Bennetts andrew at
Fri May 26 07:50:45 BST 2006

On Thu, May 25, 2006 at 09:27:55PM -0500, John Arbash Meinel wrote:
> Martin Pool wrote:
> > Is it even possible to override something called __helper?  I would have
> > thought mangling meant it always called the original implementation.
> > 
> > +1 for this patch.  One comment - since you're overriding it, perhaps
> > you should use a better name than __helper -- even just
> > _find_matching_blocks.
> > 
> I was surprised to see it work as well. But it definitely did. I always
> thought that with the mangling the parent would always call its own
> function.

Your subclass has the same name as the parent class, doesn't it?  In that case,
the mangling of your __helper will be identical to the mangling of the parent's
__helper, so the overriding magically works, even though it's a
double-underscored method.

That's a bit tricky, and worth a comment in the subclass...


More information about the bazaar mailing list