cdv test failures

John Arbash Meinel john at arbash-meinel.com
Fri May 26 03:27:55 BST 2006


Martin Pool wrote:
> On 25 May 2006, John Arbash Meinel <john at arbash-meinel.com> wrote:

...

>> It probably is better to override a non-private function anyway, since
>> that is the stable interface. __helper was probably considered an
>> implementation detail.
> 
> Is it even possible to override something called __helper?  I would have
> thought mangling meant it always called the original implementation.
> 
> +1 for this patch.  One comment - since you're overriding it, perhaps
> you should use a better name than __helper -- even just
> _find_matching_blocks.
> 

I was surprised to see it work as well. But it definitely did. I always
thought that with the mangling the parent would always call its own
function.

If you want, we could even put it inside the get_matching_blocks()
function, because we don't recurse there.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060525/4e82439b/attachment.pgp 


More information about the bazaar mailing list