cdv test failures

[Martin Pool]

On 25 May 2006, John Arbash Meinel <john at arbash-meinel.com> wrote:
> Robert Collins wrote:
> > On Wed, 2006-05-24 at 23:36 -0500, John A Meinel wrote:
> >> So it seems like we might need to copy the SequenceMatcher from the
> >> old
> >> difflib. 
> > 
> > lets do it. Also, lets send python a bug saying this should be fully and
> > cleanly overridable. :)
> > 
> > Rob
> 
> Well, it turns out that their change was to remove the __helper function
> which had a recursive definition, and switch to some inline code that
> uses a queue.
> 
> So I just needed to override get_matching_blocks() rather than
> overriding __helper().
> 
> Attached is the diff that makes the tests pass on 2.4.3.
> 
> It probably is better to override a non-private function anyway, since
> that is the stable interface. __helper was probably considered an
> implementation detail.

Is it even possible to override something called __helper?  I would have
thought mangling meant it always called the original implementation.

+1 for this patch.  One comment - since you're overriding it, perhaps
you should use a better name than __helper -- even just
_find_matching_blocks.

-- 
Martin