[PATCH] Remove config.h from DEFAULT_IGNORE

Michael Ellerman michael at ellerman.id.au
Thu May 18 07:41:01 BST 2006


On 5/18/06, Martin Pool <mbp at canonical.com> wrote:
> On 18 May 2006, Michael Ellerman <michaelellerman at gmail.com> wrote:
> > IMHO, config.h is _way_ too generic a filename to be in the default ignore
> > list.
>
> Robert has some concerns about changing the default ignore list, which I
> may be mistating but I think amount to saying that we should never
> change it, because then the behaviour of default 'add' will vary from
> one version to the next and people may ignore or add things they don't
> meant to.
>
> I disagree; keeping consistent behaviour is good but we need to have a
> way to correct our mistakes, and (for example) putting config.h in was
> such a mistake.  The change might be, at most, surprising, but it
> shouldn't cause data loss or serious inconvenience.
>
> For bugfix releases like 0.8.2 keeping the behaviour consistent is more
> important.  For example if any future 0.8.x releases go into
> dapper-updates there should be no surprising changes.

Yeah, I see Robert's point, but in this case I think it's more
confusing for an inocuous filename like 'config.h' to be ignored by
default. If I was a new user I think I would have been pretty puzzled,
as it happens I just checked the source, but most users are not going
to be doing that.

As far as 0.8.x is concerned I guess it's a little tricker. But eg. I
think it'll be a pity if people are still having to add config.h by
hand in 5 years when Dapper's retired.

cheers




More information about the bazaar mailing list