[PATCH] Remove config.h from DEFAULT_IGNORE

[Robert Collins]

On Thu, 2006-05-18 at 12:11 +1000, Martin Pool wrote:
> On 18 May 2006, Michael Ellerman <michaelellerman at gmail.com> wrote:
> > IMHO, config.h is _way_ too generic a filename to be in the default ignore 
> > list.
> > 
> > === modified file 'bzrlib/__init__.py'
> > --- bzrlib/__init__.py
> > +++ bzrlib/__init__.py
> > @@ -63,7 +63,6 @@
> >                   '_darcs',
> >                   'aclocal.m4',
> >                   'autom4te*',
> > -                  'config.h',
> >                   'config.h.in',
> >                   'config.log',
> >                   'config.status',
> 
> I agree, +1 to remove it.
> 
> Robert has some concerns about changing the default ignore list, which I
> may be mistating but I think amount to saying that we should never
> change it, because then the behaviour of default 'add' will vary from
> one version to the next and people may ignore or add things they don't
> meant to.  
> 
> I disagree; keeping consistent behaviour is good but we need to have a
> way to correct our mistakes, and (for example) putting config.h in was
> such a mistake.  The change might be, at most, surprising, but it
> shouldn't cause data loss or serious inconvenience.
> 
> For bugfix releases like 0.8.2 keeping the behaviour consistent is more
> important.  For example if any future 0.8.x releases go into
> dapper-updates there should be no surprising changes.

You're misquoting.

I think we should write the default ignore list to disk. That means that
changes in the default ignore list will only be changes to the
*defaults*. Currently the 'default' ignore list when changed affects
every user, and will give different behaviour on the same tree when used
from different machines.

I think the first priority should be blatting these default rules to
disk somehow. As soon as thats done, we can change the defaults daily if
you like with my complete support.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060519/f3b27cd8/attachment.pgp