[PATCH] Remove config.h from DEFAULT_IGNORE

Martin Pool mbp at canonical.com
Thu May 18 03:11:19 BST 2006


On 18 May 2006, Michael Ellerman <michaelellerman at gmail.com> wrote:
> IMHO, config.h is _way_ too generic a filename to be in the default ignore 
> list.
> 
> === modified file 'bzrlib/__init__.py'
> --- bzrlib/__init__.py
> +++ bzrlib/__init__.py
> @@ -63,7 +63,6 @@
>                   '_darcs',
>                   'aclocal.m4',
>                   'autom4te*',
> -                  'config.h',
>                   'config.h.in',
>                   'config.log',
>                   'config.status',

I agree, +1 to remove it.

Robert has some concerns about changing the default ignore list, which I
may be mistating but I think amount to saying that we should never
change it, because then the behaviour of default 'add' will vary from
one version to the next and people may ignore or add things they don't
meant to.  

I disagree; keeping consistent behaviour is good but we need to have a
way to correct our mistakes, and (for example) putting config.h in was
such a mistake.  The change might be, at most, surprising, but it
shouldn't cause data loss or serious inconvenience.

For bugfix releases like 0.8.2 keeping the behaviour consistent is more
important.  For example if any future 0.8.x releases go into
dapper-updates there should be no surprising changes.

-- 
Martin




More information about the bazaar mailing list