[MERGE] test-progress-bars
Martin Pool
mbp at canonical.com
Wed May 10 05:25:19 BST 2006
On 9 May 2006, Robert Collins <robertc at robertcollins.net> wrote:
> http://people.ubuntu.com/~robertc/baz2.0/test-pb has an updated, and now
> working correctly, selftest using progress bars.
>
> Diff attached against .dev.
+1 from me.
> @@ -199,12 +234,75 @@
> self.stream.writeln("%s" % err)
>
>
> -class TextTestRunner(unittest.TextTestRunner):
> +class TextTestRunner(object):
> stop_on_failure = False
I'm just curious why you changed the superclass?
> +class TestResult(TestCase):
Here you seem to be using this class both as the test, and as the test
data - which is fine, but deserves a comment or perhaps a better name -
something communicating that you're testing how results are reportd.
> +class TestRunner(TestCase):
Similarly.
--
Martin
More information about the bazaar
mailing list