[MERGE] test-progress-bars

[Robert Collins]

On Wed, 2006-05-10 at 14:25 +1000, Martin Pool wrote:
> On  9 May 2006, Robert Collins <robertc at robertcollins.net> wrote:
> > http://people.ubuntu.com/~robertc/baz2.0/test-pb has an updated, and now
> > working correctly, selftest using progress bars.
> > 
> > Diff attached against .dev.
> 
> +1 from me.
> 
> > @@ -199,12 +234,75 @@
> >              self.stream.writeln("%s" % err)
> >  
> >  
> > -class TextTestRunner(unittest.TextTestRunner):
> > +class TextTestRunner(object):
> >      stop_on_failure = False
> 
> I'm just curious why you changed the superclass?

Hmm. I dont recall now - the branch nearly went stale. I think because
we no longer use any superclass methods. 

> > +class TestResult(TestCase):
> 
> Here you seem to be using this class both as the test, and as the test
> data - which is fine, but deserves a comment or perhaps a better name -
> something communicating that you're testing how results are reportd.

Test_MyResult perhaps ? Its testing how the _MyResult class works.

> > +class TestRunner(TestCase):
> 
> Similarly.


Which is testing how our TextTestRunner behaves. TestTextTestRunner
perhaps ?

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060510/f62f5754/attachment.pgp