[merge] updated store-escaping for windows
Martin Pool
mbp at sourcefrog.net
Thu Apr 13 03:46:42 BST 2006
On 13/04/2006, at 9:38 AM, Robert Collins wrote:
>
> That new patch looks better.
>
> Some more things though - this patch breaks bzrtools - it alters the
> signature of set_inventory to require 5 rather than 4 items in each
> row.
> I know we can go and update bzrtools too - but we should document the
> API change (which has been otherwise stable for ages) in NEWS, and/or
> version this change - either probe for the number of elements or
> deprecate the current call and add a new one that takes 5 items.
> The old
> one then just rewrites the input.
I didn't intend to change the API, it just also came through from
John's old branch. I don't think it's used and it doesn't do
anything very useful, so I'll try to change it back.
In fact the WorkingTree.set_inventory API is very old fashioned in
taking a list of strings like this, so perhaps we should deprecate it
and have a new method that just takes an Inventory object? It looks
like that would fit into bzrtools OK.
> Also, you are using deprecated apis in your tests, so there is a
> lot of
> stipple created.
Also just leftover code from before; I'll have a look.
--
Martin
More information about the bazaar
mailing list