[merge] updated store-escaping for windows

[Robert Collins]

On Wed, 2006-04-12 at 16:35 +1000, Martin Pool wrote:
> On 12/04/2006, at 2:39 PM, Robert Collins wrote:
> 
> > On Tue, 2006-04-11 at 18:57 +1000, Martin Pool wrote:
> >> This change, based on John's previous work, changes Knit stores to  
> >> avoid
> >> characters in filenames that can't be safely stored on Windows.
> >> (Basically everything but lowercase letters, digits, and a few
> >> punctuation characters.)
> >>
> >> - Add a FakeVFAT transport decorator that lets us check some of these
> >>   constraints.  (Eventually it might be nice to be able to run
> >>   WorkingTree tests through this too to trap Windows-specific bugs
> >>   even when testing on Unix.)
> >>
> >> - Add an 'escaped' parameter to the TransportStore.
> >

That new patch looks better.

Some more things though - this patch breaks bzrtools - it alters the
signature of set_inventory to require 5 rather than 4 items in each row.
I know we can go and update bzrtools too - but we should document the
API change (which has been otherwise stable for ages) in NEWS, and/or
version this change - either probe for the number of elements or
deprecate the current call and add a new one that takes 5 items. The old
one then just rewrites the input.

Also, you are using deprecated apis in your tests, so there is a lot of
stipple created.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060413/0e1c7734/attachment-0001.pgp