pycurl ready to land

Robert Collins robertc at robertcollins.net
Tue Mar 7 09:14:44 GMT 2006


On Tue, 2006-03-07 at 18:45 +1100, Martin Pool wrote:
> On 6 Mar 2006, at 23:04 , Robert Collins wrote:
> 
> >> +    def should_cache(self):
> >> +        """Return True if the data pulled across should be cached
> >> locally.
> >> +        """
> >> +        return True
> >
> >
> > Is this used anywhere? should we remove it? If not - pep 8 - one line
> > for
> > ""FOO"""
> 
> Yes, this method is used and required by the test suite.  Maybe  
> someone can clarify exactly what it does?  I don't see why the  
> transport has an opinion on whether things can be safely cached.

its a hangover from 0.0.4 when we built a local disk cache of data.

> Code style things are done.

Great, bombs away!

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060307/e57843ba/attachment.pgp 


More information about the bazaar mailing list