pycurl ready to land

Martin Pool mbp at sourcefrog.net
Tue Mar 7 07:45:00 GMT 2006


On 6 Mar 2006, at 23:04 , Robert Collins wrote:

>> +    def should_cache(self):
>> +        """Return True if the data pulled across should be cached
>> locally.
>> +        """
>> +        return True
>
>
> Is this used anywhere? should we remove it? If not - pep 8 - one line
> for
> ""FOO"""

Yes, this method is used and required by the test suite.  Maybe  
someone can clarify exactly what it does?  I don't see why the  
transport has an opinion on whether things can be safely cached.

Code style things are done.

-- 
Martin Pool







More information about the bazaar mailing list