pycurl ready to land

[Robert Collins]

On Mon, 2006-03-06 at 22:37 +1100, Martin Pool wrote:
> === added directory 'b/bzrlib/transport/http'
> === added file 'b/bzrlib/transport/http/_pycurl.py'
> --- /dev/null   
> +++ b/bzrlib/transport/http/_pycurl.py  
> @@ -0,0 +1,126 @@
> +# Copyright (C) 2006 Canonical Ltd
> +
> +# This program is free software; you can redistribute it and/or
> modify
> +# it under the terms of the GNU General Public License as published
> by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> 02111-1307  USA


I mentioned this in another review, think it got lost/not resolved?

# comment

# more of same comment

is really confusing compared to 

# comment
#
# more of same comment.



> +
> +"""http/https transport using pycurl"""
> +
> +# TODO: test reporting of http errors
> +
> +from StringIO import StringIO
> +
> +import bzrlib
> +from bzrlib.trace import mutter
> +from bzrlib.errors import (TransportNotPossible, NoSuchFile,
> +                           TransportError, ConnectionError,
> +                           DependencyNotPresent)
> +from bzrlib.transport import Transport
> +from bzrlib.transport.http import HttpTransportBase, extract_auth,
> HttpServer

alphabetical order please:
bzrlib
bzrlib.errors
bzrlib.trace
bzrlib.transport
bzrlib.transport.http





> +    def should_cache(self):
> +        """Return True if the data pulled across should be cached
> locally.
> +        """
> +        return True


Is this used anywhere? should we remove it? If not - pep 8 - one line
for 
"""FOO"""

or multiple for 
"""FOO

BAR
"""

but not
"""FOO
"""


Other than that, it looks good to my 2300 hours eyes.

+1

Rob




> 
> 
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060306/8b51a06c/attachment.pgp