Tree Transform passing all tests, plus abuse

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel wrote:

> Well, you said that you fixed the PEP8 issues of transform.py, and there
> are a whole lot of missing spaces. (Between classes, at the top, etc).

I've done more PEP8 stuff.

> I certainly don't want to review Robert's changes along with yours.

Remember that diff -r ancestor:../robert is your friend.  Perhaps diff
- -r last-merge would be sweeter.

>>>>>I still don't have a good idea what changes to make here.
>>>>
>>>>I think we just need to come up with a consistent naming convention.

Okay: how about

get_id_tree      -> trans_id_tree_file_id
get_trans_id     -> trans_id_file_id
get_tree_path_id -> trans_id_tree_path
get_tree_file_id -> tree_file_id
final_file_id    -> final_file_id (unchanged)
inactive_file_id -> inactive_file_id (unchanged)

I haven't done this yet, but what do you think?

Plus, I'm adding some docs on create_path vs create_file.

> Eventually we will probably switch the display from using '/' to using
> '\' for certain cases of output to the user.
> However, I wanted everything internally consistent, before we deal with
> user presentation.

Okay, I've switched everything over to os.pathjoin

> Stuff like bzr diff is going to use '/' since that means you can mail it
> to someone else.

(Even on Windows, some versions of patch require '/' as a separator.)

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFD9fJs0F+nu1YWqI0RApHVAJ4pwnRXGtkymz26+Ngui9X583LOjwCfcJJ/
kkY2RgarWvbz/juM97SwpEE=
=1WdA
-----END PGP SIGNATURE-----