Tree Transform passing all tests, plus abuse

[John A Meinel]

Aaron Bentley wrote:
> John A Meinel wrote:
>>> You haven't pushed your latest bzr.ttransform work. So I can't review
>>> your latest changes. (I only have up to revno 1441)
> 
> 1441 was the revno I was referring to.  I've now pushed 1443, which
> merges Robert's integration.
> 

Well, you said that you fixed the PEP8 issues of transform.py, and there
are a whole lot of missing spaces. (Between classes, at the top, etc).

I thought you just didn't push the change where you fixed them.
I certainly don't want to review Robert's changes along with yours. I
suppose I can pull Robert's integration into my integration, and work
from there. I just didn't want to merge bzrdir just yet (as I think it
will break a lot of my plugins, and create even more warning showing up
on the screen).

>>>> I still don't have a good idea what changes to make here.
>>>
>>> I think we just need to come up with a consistent naming convention.
> 
> Okay, I'll look into that.
> 
>>> As long as the paths never sneak out of your tree-transform code, it
>>> won't be a problem. The issue is that anything we display to the user,
>>> or process in other commands should use '/'.
> 
> Why should anything we display to the user use '/'?  That seems a bit
> insensitive, especially if, as you say, '/'-delimited paths can't be
> used as input to Windows commands.
> 
> Anyhow, I will switch it over.  I just prefer to use standard
> functionality unless there's a good reason not to.
> 
>>> Push your work, then I'll look over it. I don't know of anything else
>>> offhand.
> 
> Pushed.
> 
> Aaron

Eventually we will probably switch the display from using '/' to using
'\' for certain cases of output to the user.
However, I wanted everything internally consistent, before we deal with
user presentation.

Stuff like bzr diff is going to use '/' since that means you can mail it
to someone else. But this goes along with the utf-8 encoding issue. And
can we separate out the function of 'bzr diff' to 'present to the user'
and 'mail to someone else'. Stuff like 'status' should use '\' to be
nice to the user.

I suppose some of this could occur in my encoding branch. Where instead
of just wrapping sys.stdout, I actually provide an custom object, which
has 'write_path()' to handle platform path issues.

I think I would rather get encoding to work, and get it merged, and then
we can make 'self.outf' something more advanced than just a codec wrapper.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060214/ccd6ac1a/attachment.pgp