Tree Transform passing all tests, plus abuse

Aaron Bentley aaron.bentley at utoronto.ca
Tue Feb 14 19:11:04 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel wrote:
> You haven't pushed your latest bzr.ttransform work. So I can't review
> your latest changes. (I only have up to revno 1441)

1441 was the revno I was referring to.  I've now pushed 1443, which
merges Robert's integration.

>>I still don't have a good idea what changes to make here.
> 
> 
> I think we just need to come up with a consistent naming convention.

Okay, I'll look into that.

> As long as the paths never sneak out of your tree-transform code, it
> won't be a problem. The issue is that anything we display to the user,
> or process in other commands should use '/'.

Why should anything we display to the user use '/'?  That seems a bit
insensitive, especially if, as you say, '/'-delimited paths can't be
used as input to Windows commands.

Anyhow, I will switch it over.  I just prefer to use standard
functionality unless there's a good reason not to.

> Push your work, then I'll look over it. I don't know of anything else
> offhand.

Pushed.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFD8itH0F+nu1YWqI0RAhMAAKCHOjLKFQe3QzYw3cW+9/eh+CAbvACff9AP
YEXe3X4LA6PbMpeI23MYWmI=
=BZpn
-----END PGP SIGNATURE-----




More information about the bazaar mailing list