[bug] Repository.copy() copies inventory first

[Robert Collins]

On Thu, 2006-02-16 at 22:14 -0600, John A Meinel wrote:
> Robert Collins wrote:
> > On Thu, 2006-02-16 at 20:01 -0600, John A Meinel wrote:
> 
> 
> ...
> 
> >> I wasn't planning on passing the inventory copy, because it is only
> >> copying a single file ('inventory.weave').
> >> Instead I figured it was better to give a specialized update which made
> >> it clear what was being copied.
> > 
> > Seems to me that transports like SFTP can provide 
> > [========           ] 'copy inventory' 150/400
> > 
> > indicators. Inventory.weave tends to get very big, and I'd expect  some
> > ui feedback during that to be nice.
> 
> That would be wonderful. But the information just isn't available.
> 'copy_multi' code only knows that it is copying a list of ids, it
> doesn't know how big any of them are. And SFTP doesn't know to put a
> progress in the case that something is bigger than X bytes.

But the sftp transport *can* do it if it chooses to. If we dont make the
pb available, then it can't. There is a bit of a confusion in the pb
management, I think 'ui_factory.progress_bar()' should know how to
nest/stack/whatever the progress bars (whether thats one instance or not
the client does not need to know. That implies we should have a
'progress_bar.finished()' or ui_factory.return_progress_bar() api too.

> Now, Repository might have an idea that inventory.weave is going to be
> big, but how does it explain that down deep into the
> LocalTransport.put(SFTPTransport.get()) call?
> 
> I suppose this is just a general communication question, and how you
> transfer information between layers.
> 
> 
> ...
> 
> > Yup. +1.
> > 
> > Rob
> 
> Merged revno 1538.

Cool.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060217/4d10467b/attachment.pgp