[bug] Repository.copy() copies inventory first

[John A Meinel]

Robert Collins wrote:
> On Thu, 2006-02-16 at 22:14 -0600, John A Meinel wrote:
>> Robert Collins wrote:
>>> On Thu, 2006-02-16 at 20:01 -0600, John A Meinel wrote:
>>
>> ...
>>
>>>> I wasn't planning on passing the inventory copy, because it is only
>>>> copying a single file ('inventory.weave').
>>>> Instead I figured it was better to give a specialized update which made
>>>> it clear what was being copied.
>>> Seems to me that transports like SFTP can provide 
>>> [========           ] 'copy inventory' 150/400
>>>
>>> indicators. Inventory.weave tends to get very big, and I'd expect  some
>>> ui feedback during that to be nice.
>> That would be wonderful. But the information just isn't available.
>> 'copy_multi' code only knows that it is copying a list of ids, it
>> doesn't know how big any of them are. And SFTP doesn't know to put a
>> progress in the case that something is bigger than X bytes.
> 
> But the sftp transport *can* do it if it chooses to. If we dont make the
> pb available, then it can't. There is a bit of a confusion in the pb
> management, I think 'ui_factory.progress_bar()' should know how to
> nest/stack/whatever the progress bars (whether thats one instance or not
> the client does not need to know. That implies we should have a
> 'progress_bar.finished()' or ui_factory.return_progress_bar() api too.
> 

Well, you would have to be passing the progress bar into the transport
layer. Which we aren't doing. (You have to first pass it to the Store,
who passes it to get/put, who passes it to Transport).

I think we need to work out how to convey information from higher to
lower levels, and a lot more needs to be done than just passing a
progress bar.

Perhaps a whole event type system, where the higher levels subscribe to
certain events when they know they will be useful.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060217/0857341f/attachment.pgp