[patch] encodings again

[John A Meinel]

Alexander Belchenko wrote:
> Robert Collins пишет:
>> On Thu, 2005-12-22 at 17:05 -0600, John A Meinel wrote:
>>
>>>
>>> PS> In case you missed the discussion, the current rule for the main
>>> branches (Robert & my integration branches, and probably bzr.dev) is
>>> that we need 2 people to review the change and give it +1. If someone
>>> else speaks up, I'll merge it into my integration branch. 
>>
>>
>> I'd really like a test for this - that the output_encoding gets
>> sys.stdout.encoding rather than bzrlib.user_encoding. With a test, +1.
> 
> OK, I'm try to write tests for log command and for commit editor.
> I find that status command also have encoding problem, I'm write the
> test and for status.
> 
> I think for commit editor is best not to invoke cat because this one
> does not exist on Windows. But instead use python itself with '-c'
> option and simple read-modify feature.
> 
> Anyway, any hints is great.
> 
> Alexander

Do you have a branch where you make these changes, or do you just prefer 
to post them as patches?
I prefer to track branches, and merge them, that way the lines will get 
annotated with your name, and you get due credit, rather than me just 
applying patches, and crediting you in the commit log.

Anyway, have you looked into writing tests, or making the changes that 
Robert suggested? I might take some time to look into this.

John
=:->