testbzr fails on windows with bad line endings.

[John A Meinel]

John A Meinel wrote:

> John A Meinel wrote:
>
>> What does the 't' stand for for opening files in 'wt' mode? After
>> looking and looking, and browsing through the python source. I think I
>> found that it means absolutely nothing to python. It seems to pass it on
>> to the fopen() command, but even with that, I can't find a definition
>> for it.
>>
> Attached is a patch which changes all instances of 'wt' into 'wb'.
>
> After applying all of the latest patches (to setup file locking under
> win32, and handle line endings, etc) all tests pass under cygwin.
>
> Nothing passes for win32 native, since that causes path names to use '\'
> instead of '/'.
>
> Is there a general consensus about how to handle paths internally? Since
> windows supports it, I think we should use '/' as the path separator. It
> just unifies platforms.
>
> I could create a patch for the self-tests, which just does a
> str.replace('\\', '/') where necessary for the tests.
>
> John
> =:->

It turns out there were only 3 selftests that had the path separator
issues. So with the attached patch (and the other ones I have submitted
today). bzr selftest passes with cygwin python2.4, and native win32
python 2.3 and 2.4.

I have a dev branch where I have done all of the changes on if my
patches are a little bit chaotic.

John
=:->

PS> tesbzr doesn't work yet, it still has some issues, but most of the
issues are problems with the test suite, not bzr itself.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: selftest-pathsep.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20050525/45df9215/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 253 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050525/45df9215/attachment.pgp