[PATCH] bzr log --revision allows ranges

[John Arbash Meinel]

Rusty Russell wrote:

>On Sat, 2005-05-14 at 09:42 -0500, John Arbash Meinel wrote:
>
>
>>I updated bzr log so that you could supply a range of revisions to
>>print. At the same time, I updated -r so that it can take a colon
>>separated list of revisions.
>>
>>
>
>Please, please.  We used colons in iptables, and I always regretted it.
>Please use "-". Since "1" is a lower bound *always*, the "-5" case is
>just silly anyway.
>
>
>
>>    bzr log -r uuid:blah-blah-blah
>>    bzr log -r hash:blahblahblah
>>    bzr log -r tag:blah
>>
>>
>
>Sure, colons are the right choice here.
>
>Thanks,
>Rusty.
>
>
Well, I only used ':' because that is what is in the documentation. I
actually prefer to use something else, because that prevents conflicts
with 'uuid:'. Though '-' conflicts with uuid as well, because uuid
already use the - separator.

Are there any other decent possibilities? What about '~', it doesn't
conflict with uuids, it looks like it could describe a range, and it
also doesn't have a potential conflict with negative numbers.

I actually would really like to be able to say "give me the last 5 logs"
and give "bzr log -r -5". And you're right, that this doesn't have to be
ambiguous if someone wants to get upto something, they can do 1-5. But
what about give me from 5 ago until 2 ago ie "-5:-2".

Anyway, any of these are really a simple fix from where I was, in about
30s I switched from : -> -, though I need to think more about how to
handle negative numbers.

I thought we might discuss it a little. I was trying to be consistent
with other commands, so you could do:

bzr merge ../other at 1:10
similar to
bzr log -r 1:10

If we switch to '-' that just changes to
bzr merge ../other at 1-10, bzr log -r 1-10
or
bzr merge ../other at 1~10, bzr log -r 1~10
bzr merge ../other at uuid:abcdef-abcd-abcd-abcd-efghijkl~uuid:anoheu-nthoeu

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 253 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20050515/1a5ddd26/attachment.pgp