[apparmor] [PATCH] parser: Preserve techdoc files in the clean target

Tyler Hicks tyhicks at canonical.com
Fri Jan 20 04:14:53 UTC 2017


The techdoc files are now part of the upstream release tarball and
should not be removed as part of the clean target.

Removing the techdoc files, especially techdoc.pdf, breaks existing
build scripts that call the clean target before building AppArmor. The
techdoc.pdf file is not generated as part of the build any longer so the
pdf will not be present at the end of the build if it was initially
deleted by the clean target.

Rather than creating a new set of maintainer-clean targets throughout
the source tree, I think it is best to simply not remove the techdoc
files via make. These are files that should only be generated when a
release is being made and, if needed, the AppArmor maintainers can use
the VCS for cleaning untracked files. The maintainer-clean targets would
be very rarely used and would needlessly complicate the Makefiles.

Signed-off-by: Tyler Hicks <tyhicks at canonical.com>
---
 parser/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/parser/Makefile b/parser/Makefile
index ca2a44e..08f89c1 100644
--- a/parser/Makefile
+++ b/parser/Makefile
@@ -393,7 +393,6 @@ clean: pod_clean
 	rm -f $(NAME)*.tar.gz $(NAME)*.tgz
 	rm -f af_names.h
 	rm -f cap_names.h
-	rm -rf techdoc.aux techdoc.out techdoc.log techdoc.pdf techdoc.toc techdoc.txt techdoc/
 	$(MAKE) -s -C $(AAREDIR) clean
 	$(MAKE) -s -C po clean
 	$(MAKE) -s -C tst clean
-- 
2.7.4




More information about the AppArmor mailing list