[apparmor] [patch] Fix a missing comma in parser_misc.c capnames

[Seth Arnold]

On Fri, Jan 15, 2016 at 01:34:58PM +0100, Christian Boltz wrote:
> Hello,
> 
> the capnames list missed a comma, which lead to the funny
> "mac_overridesyslog" capability name.
> 
> __debug_capabilities() seems to be the only user of capnames, which
> might explain why this bug wasn't noticed earlier.
> 
> 
> I propose this patch for trunk, 2.10 and 2.9.

Acked-by: Seth Arnold <seth.arnold at canonical.com>

Acked for all.

> 
> BTW: Do we really need capnames or could the code be changed to use the
> list from cap_names.h?

It sure looksl ike cap_names.h could be used instead. It'd require
modifying the search routines but might make a fun weekend project for
someone interested in learning C better. :)

Thanks

> 
> [ parser-fix-missing-comma.diff ]
> 
> === modified file 'parser/parser_misc.c'
> --- parser/parser_misc.c        2015-07-11 01:16:09 +0000
> +++ parser/parser_misc.c        2016-01-15 12:15:53 +0000
> @@ -724,7 +724,7 @@
>         "audit_write",
>         "audit_control",
>         "setfcap",
> -       "mac_override"
> +       "mac_override",
>         "syslog",
>  };
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20160115/5623034f/attachment.pgp>