[apparmor] [patch] Fix a missing comma in parser_misc.c capnames

Christian Boltz apparmor at cboltz.de
Fri Jan 15 12:34:58 UTC 2016


Hello,

the capnames list missed a comma, which lead to the funny
"mac_overridesyslog" capability name.

__debug_capabilities() seems to be the only user of capnames, which
might explain why this bug wasn't noticed earlier.


I propose this patch for trunk, 2.10 and 2.9.


BTW: Do we really need capnames or could the code be changed to use the
list from cap_names.h?


[ parser-fix-missing-comma.diff ]

=== modified file 'parser/parser_misc.c'
--- parser/parser_misc.c        2015-07-11 01:16:09 +0000
+++ parser/parser_misc.c        2016-01-15 12:15:53 +0000
@@ -724,7 +724,7 @@
        "audit_write",
        "audit_control",
        "setfcap",
-       "mac_override"
+       "mac_override",
        "syslog",
 };
 



Regards,

Christian Boltz
-- 
Durr, shouldn't send emails before having my morning coffee.
[Steve Beattie in apparmor]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20160115/7842cfbc/attachment.pgp>


More information about the AppArmor mailing list