[apparmor] [patch] aa-genprof: fix byte vs. string and wrong filename

[Christian Boltz]

Hello,

Am Mittwoch, 21. Mai 2014 schrieb Kshitij Gupta:
> On Wed, May 21, 2014 at 12:54 PM, Kshitij Gupta wrote:
> > Hello,
> > 
> > (Long time no see ;-) )

Indeed - where did you hide? ;-)

> > On Mon, May 19, 2014 at 5:47 AM, Christian Boltz wrote:
> >> BTW: there's another hardcoded /var/log/audit.log in aa-genprof:
> >> 
> >> if os.path.exists('/var/log/audit/audit.log'):
> >>     syslog = False
> >> 
> >> Does this also need a change to honor the -f parameter?
> > 
> > Yes, you're right the -f param is not being honored. The code
> > basically is supposed to default to the system logger
> > (/usr/bin/logger) incase the /var/log/audit/audit.log did not exist,
> > which would be silly if the audit.log did not exist in the system
> > when user gave a custom log source.

> Acked-by: Kshitij Gupta <kgupta8592 at gmail.com>

Thanks, commited.

> Please commit the patch along with thesuggested change for the -f
> option.

I first have to think about the correct solution a bit [1]. It will 
probably be a one-line patch, but it should do the right thing ;-)

I'll send a separate patch for this.


Regards,

Christian Boltz

[1] and I need some free time to do this, which is the bigger problem at 
    the moment ;-)

-- 
> [lost password] Not that i know much of encrypted FS's, but id say you
> are pretty lost by then. Unless you can brutecrack the encryption with
> some forensics software...
Start looking for post-it notes near the console....
[> Antun Balaz and Tom Knight in suse-security]