[apparmor] [PATCH 11/36] apparmor: Add interface files for profiles and namespaces

[Seth Arnold]

On Thu, May 09, 2013 at 02:58:40AM -0700, John Johansen wrote:
> >> -static struct aa_fs_entry aa_fs_entry =
> >> -	AA_FS_DIR("apparmor", aa_fs_entry_apparmor);
> >> +static struct aa_fs_entry aa_fs_entry[] = {
> >> +	AA_FS_DIR("apparmor", aa_fs_entry_apparmor),
> >> +	{ }
> >> +};
> > 
> > I didn't see the reasoning behind this change.. nothing really wrong
> > with it, but it appeared to just complicate nearly every line of code
> > that touched aa_fs_entry, except one..
> > 
> the { } entry is needed otherwise we can walk off the end of the array in
> some of the loop code. ie its a necessary terminator

Except I haven't spotted the iteration over the one-element-array yet.. :)

Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20130509/c387bd6d/attachment.pgp>