[apparmor] [opensuse-project] Google Summer of Code'13 accepted student

[John Johansen]

On 06/01/2013 03:30 AM, Kshitij Gupta wrote:
> Hello,
> 
> Okay, I'm assured that I wont be getting anybody mad my by mails. Hopefully I wont make it to 200 mails a day. ;-)
> 
> @Seth @Christian okay, I'll try my hands at the wiki.apparmor.net <http://wiki.apparmor.net> in a day or two and see what I can do to make a suggestion/idea of it.
> 
> @Christian there's the first module [1] I talked about yesterday. I know its tiny compared to what I have to write, but I'd still like feedback on the style, so I can adjust myself (like your views on docstrings, whether you would prefer string.split over the re module etc). I have left a doubt as comments in the module maybe somebody can answer that.
> 
So just a few general comments

I don't care either way about docstrings, though reST seems to be popular in
the python world. Basically I find auto generated documentation useless if
you have the source. In opensource what counts is good commenting and if you
have your comments in a format that can be used to autogenerate docs great,
but its not really important. I NEVER look at autogenerated docs unless I
have no other choice. And I feel like strangling people who point me at
autogenerated docs as Documentation for a project. When I am looking for docs
its something at a different level than code and comments in code. Of course
when you are dealing with a proprietary code base then a doc string based
approach is better than no docs. Again this should not really be an issue
for opensource, choose the format that suites you and just try to make good
comments.

string.split is simple and has its place, basically I have no qualms about
using either/or both as is appropriate. If string.split makes the code
cleaner and easier to read use it, if re is the right choice use it. There
will be points where you need to use re so you will be including the re
module anyways.

The logprof.conf config format is awful close to that supported by python's
ConfigParser http://docs.python.org/2/library/configparser.html, I'd look at
that and double check whether we can't just use that

For writing a conf file (or any small file you really care about), ideally
you create a temp copy on write and then move it into place so you don't
trash the original file if there is an error.


> Also, just out of curiosity why was the utility package in perl named Immunix? Any specific reasons behind it?
> 
Long ago Immunix was the company/Linux variant that apparmor (at the time it
was called subdomain) was being developed at/for. Immunix was aquired by
Novell (suse) and subdomain was renamed to apparmor and opensourced

There is no reason to retain the Immunix name in anything we do

> [ 1 ]- http://bazaar.launchpad.net/~kgupta8592/apparmor-profile-tools/trunk/view/head:/lib/config.py <http://bazaar.launchpad.net/%7Ekgupta8592/apparmor-profile-tools/trunk/view/head:/lib/config.py>
> 
> Regards,
> Kshitij
> 
> <--Sig coming later than thought ;-)-->
> <http://bazaar.launchpad.net/~kgupta8592/apparmor-profile-tools/trunk/view/head:/lib/config.py>
> 
> 
> On Sat, Jun 1, 2013 at 2:13 AM, Christian Boltz <apparmor at cboltz.de <mailto:apparmor at cboltz.de>> wrote:
> 
>     Hello,
> 
>     Am Freitag, 31. Mai 2013 schrieb Kshitij Gupta:
>     > I just thought some people might get annoyed by the unnecessary mails
>     > piling up in their inbox. We actually had that problem on the GSoC
>     > students mailing list lately, but I'll take your word for it.
> 
>     See Seth's reply - with some filtering, handling large amounts of mails
>     isn't a problem. Just to give you some numbers - some years ago, the
>     german opensuse mailinglist had up to 200 mails per day (!) ;-)
> 
>     > @John, @Seth and @Christian thanks for those ideas about features
>     > (keep them coming :-) ), I'll get back to you about the details on
>     > those ideas in a day or two. Meanwhile, I propose we have a feature
>     > request list type of thing? I'm not sure but would the Blueprint
>     > section of Launchpad be appropriate for it (or any other place that
>     > everyone can view and edit)?
> 
>     Blueprint or wiki.apparmor.net <http://wiki.apparmor.net> - whatever you prefer ;-)
>     (I'm not sure if Blueprint fits "everyone can [...] edit" - Seth/John?)
> 
>     > Meanwhile, I have been thinking of doing the bottom-up style
>     > development starting from the core libraries moving upwards to the
>     > tools. So, I'll have a basic version of a module out of those for you
>     > guys to review by tomorrow (hopefully).
> 
>     Sounds very promising :-)
> 
>     > I'd love some input in that
>     > direction. Anything about organisation of libraries etc.
> 
>     I'm quite sure you learned those things at university, so you'll be able
>     to come up with a good code layout. In other words: "whatever makes
>     sense" ;-)  We'll of course provide feedback as early as possible.
> 
> 
>     Regards,
> 
>     Christian Boltz
>     --
>     > Und nun rate mal, warum ausgerechnet v.a. Vielschreiber mutt
>     > verwenden. Sicher nicht, weil KMail besser waere.
>     Weil eine Handvoll muttschisten die alle dazu gezwungen hat? ;)
>     [> David Haller und Manfred Misch in suse-linux]
> 
> 
>     --
>     AppArmor mailing list
>     AppArmor at lists.ubuntu.com <mailto:AppArmor at lists.ubuntu.com>
>     Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
> 
> 
> 
>