[apparmor] [patch] fix libapparmor ruby bindings for ruby 2.0

Christian Boltz apparmor at cboltz.de
Wed Jun 5 20:23:41 UTC 2013


Hello,

you might have noticed the discussion about the libapparmor ruby 
bindings build failures on openSUSE Factory, which is the first version 
with ruby 2.0.

The problem was that DESTDIR was added to too many variables, which 
finally resulted in

[ 1399s] make[4]: Entering directory
`/home/abuild/rpmbuild/BUILD/apparmor-2.8.1/libraries/libapparmor/swig/ruby'
[ 1399s] make[4]: *** No rule to make target
`/home/abuild/rpmbuild/BUILDROOT/apparmor-2.8.1-147.1.x86_64/usr/include/ruby-2.0.0/ruby.h',

See https://bugzilla.novell.com/show_bug.cgi?id=822277 for all details.


Klaus Kaempf provided the attached patch which fixes the build, but he 
intentionally enabled it for Factory builds only (not <= 12.3) and wrote 
about it in the bugreport:

(comment 8)
Added a clunky workaround: created request id 177452
Should be fixed upstream

(comment 10)
Well, it is a crude hack, based on the contents of the created 
Makefile(.ruby)
Other distributions have different Makefiles (hence this bug doesn't 
appear there) and the patch might create more harm.


The only thing I can say about the patch is that it fixes the problem.
I don't know if it breaks anything on other distributions etc., 
therefore I'm asking for an extra strict review (and some testing) ;-)


Regards,

Christian Boltz
-- 
> Ich geh' jetzt erstmal Gummienten beim Wettschwimmen zugucken...
Du Gluecklicher. Ich darf morgen "echten" eNTen beim Umfallen zuschaun.
                            [Jochen Erwied und Thomas Ogrisegg in dasr]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ruby-2_0-mkmf-destdir.patch
Type: text/x-patch
Size: 1080 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/apparmor/attachments/20130605/4c50272d/attachment.bin>


More information about the AppArmor mailing list