[Merge] lp:~xnox/upstart/shrink-notifications into lp:upstart

James Hunt james.hunt at canonical.com
Wed Jul 2 13:21:46 UTC 2014


Review: Needs Fixing

Thanks! However, test_job_process.c is still failing for me:

#2  0x0000000000433a2d in test_start () at tests/test_job_process.c:4160
4160            TEST_FILE_END (output);

Also, re-exec is failing occasionally for me with EBADF thrown by nih_io_reopen().

Also, could you remove that stale comment in job_process_close_handler().
-- 
https://code.launchpad.net/~xnox/upstart/shrink-notifications/+merge/225200
Your team Upstart Reviewers is subscribed to branch lp:upstart.



More information about the upstart-devel mailing list