[Merge] lp:~xnox/upstart/shrink-notifications into lp:upstart

Dimitri John Ledkov launchpad at surgut.co.uk
Thu Jul 3 13:48:32 UTC 2014


> Thanks! However, test_job_process.c is still failing for me:
> 
> #2  0x0000000000433a2d in test_start () at tests/test_job_process.c:4160
> 4160            TEST_FILE_END (output);
> 

That test is racy since async branch introduction and has a comment to denote as such. I've not committed a couple of guards to reduce spurious failures of this test, by waiting for sufficiently large enough log file to be written.

> Also, re-exec is failing occasionally for me with EBADF thrown by
> nih_io_reopen().
> 

=/ 

> Also, could you remove that stale comment in job_process_close_handler().

Done.
-- 
https://code.launchpad.net/~xnox/upstart/shrink-notifications/+merge/225200
Your team Upstart Reviewers is subscribed to branch lp:upstart.



More information about the upstart-devel mailing list