[Merge] lp:~jamesodhunt/upstart/bug-1240686 into lp:upstart

[James Hunt]

James Hunt has proposed merging lp:~jamesodhunt/upstart/bug-1240686 into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)
Related bugs:
  Bug #1240686 in upstart : "Upstart overrides the user's umask"
  https://bugs.launchpad.net/upstart/+bug/1240686

For more details, see:
https://code.launchpad.net/~jamesodhunt/upstart/bug-1240686/+merge/191771

* init/job_class.c:
  - job_class_new(): Set umask for job to current value for Session
    Init by default (LP: #1240686).
* init/job_process.c: Comments.
* init/main.c: main(): Save current umask.
* test/test_util_common.c:
  - start_upstart_common(): Add extra param for inheriting environment
    rather than hard-coding '--no-inherit-env'.
  - start_upstart(: Updated call to start_upstart_common().
* init/tests/test_main.c: Updated calls to start_upstart_common().
* test/test_util_common.h: START_UPSTART(): Updated call to
  start_upstart_common().
* util/tests/test_initctl.c:
  - Updated calls to start_upstart_common().
  - test_umask(): New tests:
    - "ensure Session Init inherits umask by default"
    - "ensure Session Init defaults umask with '--no-inherit-env'"

No impact on re-exec since umask is retained across an exec.
-- 
https://code.launchpad.net/~jamesodhunt/upstart/bug-1240686/+merge/191771
Your team Upstart Reviewers is requested to review the proposed merge of lp:~jamesodhunt/upstart/bug-1240686 into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 16806 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20131018/01fddc46/attachment.diff>