[Merge] lp:~jamesodhunt/upstart/check-for-overlayfs into lp:upstart

[James Hunt]

James Hunt has proposed merging lp:~jamesodhunt/upstart/check-for-overlayfs into lp:upstart.

Requested reviews:
  Steve Langasek (vorlon)

For more details, see:
https://code.launchpad.net/~jamesodhunt/upstart/check-for-overlayfs/+merge/191393

* test/tests/test_util_check_env.c: New test to look for
  overlayfs filesystems which could cause tests to fail.
* test/Makefile.am: Added test_util_check_env meta-test.
* test/test_util_common.c: Formatting.

This branch introduces a new meta-test that currently checks for overlayfs. It will produce a warning that tests will probably fail (due to bug LP:#882147) but does not actually abort the test run since:

- the invoker may know better whether a particular FS could cause problems for the tests.
- overlayfs may one day get fixed so hard-failing would be incorrect behaviour.

Note that the new test will be run before any other test. Further, note that since the overlayfs check is a separate test, if an individual test is run in an overlayfs environment, the invoker may be unaware of the strange resultant test failures. However, having a separate test does mean that we avoid linking every test against libnih-dbus et al.

-- 
https://code.launchpad.net/~jamesodhunt/upstart/check-for-overlayfs/+merge/191393
Your team Upstart Reviewers is subscribed to branch lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5143 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20131017/3679e7e1/attachment.diff>