[Merge] lp:~ted/upstart/dbus-arguments into lp:upstart
Ted Gould
ted at gould.cx
Mon Jul 8 17:04:33 UTC 2013
On Mon, 2013-07-08 at 09:39 -0700, Steve Langasek wrote:
> On Mon, Jul 08, 2013 at 03:33:30PM -0000, James Hunt wrote:
>
> > - Since we've already released upstart 1.9 including the
> > upstart-dbus-bridge, we need to think about how to
> > handle/break/deprecate the existing 'dbus' event.
>
> Considering this was pushed to trunk in advance of resolving this multiple
> bus question on the grounds that it was useful in its current form and only
> needed extended, yes.
>
> > Allowing the event name to be configurable
> > (lp:~ted/upstart/dbus-configure-event) may be the best way to do it I
> > guess, although the ideal would be to able to support:
>
> > dbus BUS=system SIGNAL=...
> > dbus BUS=session SIGNAL=...
> > dbus BUS=unix:abstract=/com/ubuntu/upstart-session/1000/2536 SIGNAL=...
>
> I agree that this would be preferred, not just for compatibility but I think
> in terms of overall semantics for such an event.
You guys are commenting on the wrong branch :-)
Changed it to add the bus name on the event here:
https://code.launchpad.net/~ted/upstart/dbus-configure-event/+merge/172381
Then adjusted the jobs here:
https://code.launchpad.net/~ted/upstart/session-jobs/+merge/172384
I made the bus name configurable because there has generally been talk
in the dbus community before about creating a "user" bus. That would be
one per-user independent of sessions. I figured this would allow us to
have other named buses as well. Perhaps a "unity" bus or something like
that, without having to put the full abstract path in.
--
https://code.launchpad.net/~ted/upstart/dbus-arguments/+merge/172385
Your team Upstart Reviewers is requested to review the proposed merge of lp:~ted/upstart/dbus-arguments into lp:upstart.
More information about the upstart-devel
mailing list