[PATCH] Support job logging for system jobs.

[Mark Russell]

On 12/06/2011 12:12 PM, James Hunt wrote:
> Hi All,
> 
> This is a rework of the original patch ([1]). Note that due to issues found in testing and the size
> and complexity of the full feature changes, this patch *only* adds support for the logging of output
> from system jobs. Until the follow-on patch for adding support for user jobs (currently in
> progress), if a user job specifies "console log" it will be considered to have specified "console none".
> 
> The patch also now considers out-of-space scenario explicitly: the approach taken is simple - if
> there is insufficient space to write the data, it is discarded (effectively like "console none").
> However, if space subsequently becomes free, that data will be written. Note this could result in
> files with "holes" in the data, but in edge cases such as this, buffering potentially large amounts
> of data (potentially indefinitely) within init itself is not a good idea.
> 
> Full details are in the man page init/man/init.5.
> 
> Code [2]:
> 
>   lp:~jamesodhunt/upstart/job-logging-system-jobs-only
> 
> Browseable code:
> 
>   http://bazaar.launchpad.net/~jamesodhunt/upstart/job-logging-system-jobs-only/files
> 
> Comments welcome.
> 

Will this land in precise or a ppa soonish?  I'd love to see it.

That sounds like a sane approach for the disk space issue.  There is no
perfect solution, but your approach one puts system stability first I
think.  Sounds right to me.

Thanks,
Mark


> Kind regards,
> 
> James.
> 
> [1] - https://lists.ubuntu.com/archives/upstart-devel/2011-October/001735.html
> [2] - Patch too big to send to list directly.
> --
> James Hunt
> ____________________________________
> http://upstart.ubuntu.com/cookbook
> http://upstart.ubuntu.com/cookbook/upstart_cookbook.pdf
> 
> 
> 


-- 
Mark Russell
Premium Service Architect | Canonical, Ltd.
<mark.russell at canonical.com> | GPG: 4096R/B3BBA7D1

www.ubuntu.com | www.canonical.com