0.3.2 cfg_visitor() definition consistency problem

Scott James Remnant scott at netsplit.com
Fri Feb 9 13:36:27 GMT 2007


On Thu, 2007-02-08 at 23:24 -0500, Liu Bin wrote:

> In init/cfgfile.c, function cfg_visitor() is defined with 3
> parameters. When passed to nih_dir_walk() as a parameter in
> cfg_watch_dir(), it is casted to NihFileVisitor, which is defined with
> 4 parameters in nih/file.h.
> 
> cfg_visitor() is called eventually in nih_dir_walk_visit() by always
> passing "/etc/event.d" as the 2nd parameter, instead of passing
> "/etc/event.d/<jobname>", in the simplified case - event.d has no
> subdirectories. Therefore, it cannot create the job list - jobs.
> 
Thanks, well caught.

As noted in TODO, I hadn't got around to testing this bit yet.

Fixed in bzr trunk

Scott
-- 
Have you ever, ever felt like this?
Had strange things happen?  Are you going round the twist?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/upstart-devel/attachments/20070209/fbe36f77/attachment.pgp 


More information about the upstart-devel mailing list