vde2: vdeq intermittently sets wrong permissions

[Andrew Farmer]

Package: vde2
Version: 2.1.6+r154-1
Severity: important
Tags: patch

vdeq sometimes sets inappropriate permissions on a temporary socket,
leading to intermittent failures to connect to a switch:

  vde_switch: Data_out socket permission: Permission denied

This appears to be the result of an uninitialized variable in vdeq which
leads the socket to be created with a random mode. A patch for this, as
well as for another uninitialized variable in the tool, follows.


--- vde2-2.1.6+r154/qemu/vdeq.c 2006-12-21 07:52:39.000000000 -0800
+++ vde2-patch/qemu/vdeq.c      2008-09-28 18:44:03.000000000 -0700
@@ -238,7 +238,7 @@
 
 int main(int argc, char **argv)
 {
-  char *argsock,**sockname;
+  char *argsock=NULL,**sockname;
        int *ports;
   int result;
   register ssize_t nx;
@@ -250,7 +250,7 @@
        int oldsyntax=0;
        int newsyntax=0;
        int ver;
-  mode_t mode;
+  mode_t mode=0700;
 
   vdeqname=basename(argv[0]);
        //callerpwd=getpwuid(getuid());


-- System Information:
Debian Release: lenny/sid
  APT prefers hardy-updates
  APT policy: (500, 'hardy-updates'), (500, 'hardy-security'), (500, 'hardy')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-19-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages vde2 depends on:
ii  adduser                    3.105ubuntu1  add and remove users and groups
ii  libc6                      2.7-10ubuntu4 GNU C Library: Shared libraries
ii  libvdeplug2                2.1.6+r154-1  Virtual Distributed Ethernet - Plu

Versions of packages vde2 recommends:
ii  daemon                        0.6.3-1    turns other processes into daemons

-- no debconf information