Review for sugar-memorize-activity

[Luke Faraone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Kandarp,

Review based off commit 08650be.

 * debian/copyright:
   - All of the entries for the speak/ folder could be collapsed into
one entry:

        Files: speak/*
        Copyright: © 2008  Joshua Minor
                   © 2007  Arjun Sarwal
        License: GPL-2+

 * debian/watch:
   - You can remove the "# REPLACE WITH THE PROPER USCAN-ized URL TO
UPSTREAM" comment from the file.

  * debian/source/format:
    - Your package should declare it is using the "3.0 (quilt)" source
package format. See
<http://wiki.debian.org/Projects/DebSrc3.0#Howtoconvertasourcepackage.3F> for
more

  * debian/source/include-binaries:
    - When you convert to quilt as I mentioned above, you'll need to do
"echo debian/copyright_hints >> debian/source/include-binaries" so that
dpkg-source won't balk at the binary contents of debian/copyright_hints.

 * debian/rules:
   - Remove two redundant copies of COPYING in package after build¹
   - MANIFEST is autogenerated by the package during the build process
and not removed. You should remove it in the clean stage.

¹:
Lintian reports the following:
W: sugar-memorize-activity: extra-license-file
usr/share/sugar/activities/Memorize.activity/port/COPYING
W: sugar-memorize-activity: extra-license-file
usr/share/sugar/activities/Memorize.activity/speak/COPYING

You should remove those files in the install stage.

See <http://build-common.alioth.debian.org/cdbs-doc.html#id2542963> and
the "install[...]" section of
<http://git.debian.org/?p=collab-maint/sugar-flipsticks-activity.git;a=blob;f=debian/rules>
for info and examples.


Thanks for your work,
Luke Faraone
http://luke.faraone.cc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkw7ZxYACgkQtrC51grHAgZfYwCglkfvsaOLrHBxlA66fcYaO7BX
MNMAnj9d+nP3Vq0erZVQRGNvvhYzu6Uv
=SHUv
-----END PGP SIGNATURE-----