Review of sugar-connect-activity

[Luke Faraone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On 07/12/2010 01:13 PM, Luke Faraone wrote:
> > Kandarp,
> >
> > On 07/10/2010 05:11 AM, Kandarp Kaushik wrote:
>> >> I've pushed the updated connect-activity. Please review it whenever
>> >> you find time.
> >
> > Review based off commit 8abd233.
Review based off commit 1ce30b9.

Just FYI, you shouldn't commit when you just build the package, as you
did in 185e46e. This just adds dummy files to the repo which serve no
purpose. (you later removed them, but they'll be preserved in history
for the future)

I made some changes, be sure to pull them in. Things for you to fix
follows:

   * debian/rules:
     -  Lines 31, 32, and 33 are redundant and serve no purpose.
(CDBS_DEPENDS is even overwritten later in the file!)

   * debian/changelog:
     - Line 4 where you mention switch to dpkg-source 3.0 isn't useful,
and should be removed. You haven't released the package yet, how could
you switch from something? :)

   * debian/control.in:
     - Line 26 is 74 characters long. Please wrap it to 72.

   * debian/copyright:
     - Line 21: Use commas to separate file names, as done below:
> >         Files: buddiespanel.py, game.py, gridwidget.py, infopanel.py,
> > widgettest.py
   * debian/README.source:
     - We don't track a upstream-git branch, therefore lines 17 through
74 are not applicable, and should be removed. (this applies to all of
our packages)

   * debian/stamps-configure/:
     - This folder can be removed.

Thanks,

Luke Faraone
http://luke.faraone.cc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkw+iUAACgkQtrC51grHAgbIWwCfQeFAUby9OKCm4aqMrPWPLHMs
tOUAnj4eojftSAY0n1/TDcmQDd2W307i
=RkTY
-----END PGP SIGNATURE-----