[Bug 2091499] Re: librem-ec-acpi-dkms FTBS in Noble with linux-6.11-hwe kernel

[Timo Aaltonen]

Hello Massimiliano, or anyone else affected,

Accepted librem-ec-acpi into noble-proposed. The package will build now
and be available at https://launchpad.net/ubuntu/+source/librem-ec-
acpi/0.9.2-1ubuntu1.1 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
noble to verification-done-noble. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-noble. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: librem-ec-acpi (Ubuntu Noble)
       Status: In Progress => Fix Committed

** Changed in: librem-ec-acpi (Ubuntu)
       Status: In Progress => Invalid

** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2091499

Title:
  librem-ec-acpi-dkms FTBS in Noble with linux-6.11-hwe kernel

Status in librem-ec-acpi package in Ubuntu:
  Invalid
Status in librem-ec-acpi source package in Noble:
  Fix Committed

Bug description:
  [ Impact ]

  librem-ec-acpi-dkms does not compile from source in Noble with kernel
  6.11:

  /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:10: error: ‘struct acpi_driver’ has no member named ‘owner’
    782 |         .owner = THIS_MODULE,
        |          ^~~~~
  In file included from ./arch/x86/include/asm/mem_encrypt.h:15,
                   from ./include/linux/mem_encrypt.h:17,
                   from ./arch/x86/include/asm/processor-flags.h:6,
                   from ./arch/x86/include/asm/irqflags.h:5,
                   from ./include/linux/irqflags.h:18,
                   from ./include/linux/spinlock.h:59,
                   from ./include/linux/mmzone.h:8,
                   from ./include/linux/gfp.h:7,
                   from ./include/linux/slab.h:16,
                   from ./include/linux/resource_ext.h:11,
                   from ./include/linux/acpi.h:13,
                   from /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:16:
  ./include/linux/init.h:180:21: warning: initialization of ‘char’ from ‘struct module *’ makes integer from pointer without a cast [-Wint-conversion]
    180 | #define THIS_MODULE (&__this_module)
        |                     ^
  /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
    782 |         .owner = THIS_MODULE,
        |                  ^~~~~~~~~~~
  ./include/linux/init.h:180:21: note: (near initialization for ‘librem_ec_driver.class[0]’)
    180 | #define THIS_MODULE (&__this_module)
        |                     ^
  /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
    782 |         .owner = THIS_MODULE,
        |                  ^~~~~~~~~~~
  ./include/linux/init.h:180:21: error: initializer element is not computable at load time
    180 | #define THIS_MODULE (&__this_module)
        |                     ^
  /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
    782 |         .owner = THIS_MODULE,
        |                  ^~~~~~~~~~~
  ./include/linux/init.h:180:21: note: (near initialization for ‘librem_ec_driver.class[0]’)
    180 | #define THIS_MODULE (&__this_module)
        |                     ^
  /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
    782 |         .owner = THIS_MODULE,
        |                  ^~~~~~~~~~~
  /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:780:46: warning: missing braces around initializer [-Wmissing-braces]
    780 | static struct acpi_driver librem_ec_driver = {
        |

  [ Test case ]

  Install the latest linux-6.11 kernel on Noble:

  $ sudo add-apt-repository ppa:canonical-kernel-team/ppa
  $ sudo apt update
  $ sudo apt install linux-image-6.11.0-12-generic \
                     linux-modules-6.11.0-12-generic \
                     linux-modules-extra-6.11.0-12-generic \
                     linux-headers-6.11.0-12-generic

  Install librem-ec-acpi-dkms:

  $ sudo apt install librem-ec-acpi-dkms

  Load the module:

  $ sudo modprobe librem-ec-acpi

  The same procedure should be repeated on linux-6.8 to test for
  possible regressions.

  [ Fix ]

  Patch the code to properly support the new linux 6.11 ABI.

  [ Regression potential ]

  A regression is unlikely due to the limited scope of the patch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/librem-ec-acpi/+bug/2091499/+subscriptions