[Bug 2091499] Re: librem-ec-acpi-dkms FTBS in Noble with linux-6.11-hwe kernel
Massimiliano Pellizzer
2091499 at bugs.launchpad.net
Mon Dec 16 06:57:13 UTC 2024
** Description changed:
[ Impact ]
librem-ec-acpi-dkms does not compile from source in Noble with kernel
6.11:
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:10: error: ‘struct acpi_driver’ has no member named ‘owner’
- 782 | .owner = THIS_MODULE,
- | ^~~~~
+ 782 | .owner = THIS_MODULE,
+ | ^~~~~
In file included from ./arch/x86/include/asm/mem_encrypt.h:15,
- from ./include/linux/mem_encrypt.h:17,
- from ./arch/x86/include/asm/processor-flags.h:6,
- from ./arch/x86/include/asm/irqflags.h:5,
- from ./include/linux/irqflags.h:18,
- from ./include/linux/spinlock.h:59,
- from ./include/linux/mmzone.h:8,
- from ./include/linux/gfp.h:7,
- from ./include/linux/slab.h:16,
- from ./include/linux/resource_ext.h:11,
- from ./include/linux/acpi.h:13,
- from /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:16:
+ from ./include/linux/mem_encrypt.h:17,
+ from ./arch/x86/include/asm/processor-flags.h:6,
+ from ./arch/x86/include/asm/irqflags.h:5,
+ from ./include/linux/irqflags.h:18,
+ from ./include/linux/spinlock.h:59,
+ from ./include/linux/mmzone.h:8,
+ from ./include/linux/gfp.h:7,
+ from ./include/linux/slab.h:16,
+ from ./include/linux/resource_ext.h:11,
+ from ./include/linux/acpi.h:13,
+ from /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:16:
./include/linux/init.h:180:21: warning: initialization of ‘char’ from ‘struct module *’ makes integer from pointer without a cast [-Wint-conversion]
- 180 | #define THIS_MODULE (&__this_module)
- | ^
+ 180 | #define THIS_MODULE (&__this_module)
+ | ^
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
- 782 | .owner = THIS_MODULE,
- | ^~~~~~~~~~~
+ 782 | .owner = THIS_MODULE,
+ | ^~~~~~~~~~~
./include/linux/init.h:180:21: note: (near initialization for ‘librem_ec_driver.class[0]’)
- 180 | #define THIS_MODULE (&__this_module)
- | ^
+ 180 | #define THIS_MODULE (&__this_module)
+ | ^
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
- 782 | .owner = THIS_MODULE,
- | ^~~~~~~~~~~
+ 782 | .owner = THIS_MODULE,
+ | ^~~~~~~~~~~
./include/linux/init.h:180:21: error: initializer element is not computable at load time
- 180 | #define THIS_MODULE (&__this_module)
- | ^
+ 180 | #define THIS_MODULE (&__this_module)
+ | ^
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
- 782 | .owner = THIS_MODULE,
- | ^~~~~~~~~~~
+ 782 | .owner = THIS_MODULE,
+ | ^~~~~~~~~~~
./include/linux/init.h:180:21: note: (near initialization for ‘librem_ec_driver.class[0]’)
- 180 | #define THIS_MODULE (&__this_module)
- | ^
+ 180 | #define THIS_MODULE (&__this_module)
+ | ^
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
- 782 | .owner = THIS_MODULE,
- | ^~~~~~~~~~~
+ 782 | .owner = THIS_MODULE,
+ | ^~~~~~~~~~~
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:780:46: warning: missing braces around initializer [-Wmissing-braces]
- 780 | static struct acpi_driver librem_ec_driver = {
- |
+ 780 | static struct acpi_driver librem_ec_driver = {
+ |
[ Test case ]
Install the latest linux-6.11 kernel on Noble:
$ sudo add-apt-repository ppa:canonical-kernel-team/ppa
$ sudo apt update
$ sudo apt install linux-image-6.11.0-12-generic \
- linux-modules-6.11.0-12-generic \
- linux-modules-extra-6.11.0-12-generic \
- linux-headers-6.11.0-12-generic
+ linux-modules-6.11.0-12-generic \
+ linux-modules-extra-6.11.0-12-generic \
+ linux-headers-6.11.0-12-generic
Install librem-ec-acpi-dkms:
$ sudo apt install librem-ec-acpi-dkms
Load the module:
$ sudo modprobe librem-ec-acpi
+ The same procedure should be repeated on linux-6.8 to test for possible
+ regressions.
+
[ Fix ]
Patch the code to properly support the new linux 6.11 ABI.
[ Regression potential ]
A regression is unlikely due to the limited scope of the patch.
--
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2091499
Title:
librem-ec-acpi-dkms FTBS in Noble with linux-6.11-hwe kernel
Status in librem-ec-acpi package in Ubuntu:
In Progress
Status in librem-ec-acpi source package in Noble:
In Progress
Bug description:
[ Impact ]
librem-ec-acpi-dkms does not compile from source in Noble with kernel
6.11:
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:10: error: ‘struct acpi_driver’ has no member named ‘owner’
782 | .owner = THIS_MODULE,
| ^~~~~
In file included from ./arch/x86/include/asm/mem_encrypt.h:15,
from ./include/linux/mem_encrypt.h:17,
from ./arch/x86/include/asm/processor-flags.h:6,
from ./arch/x86/include/asm/irqflags.h:5,
from ./include/linux/irqflags.h:18,
from ./include/linux/spinlock.h:59,
from ./include/linux/mmzone.h:8,
from ./include/linux/gfp.h:7,
from ./include/linux/slab.h:16,
from ./include/linux/resource_ext.h:11,
from ./include/linux/acpi.h:13,
from /var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:16:
./include/linux/init.h:180:21: warning: initialization of ‘char’ from ‘struct module *’ makes integer from pointer without a cast [-Wint-conversion]
180 | #define THIS_MODULE (&__this_module)
| ^
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
782 | .owner = THIS_MODULE,
| ^~~~~~~~~~~
./include/linux/init.h:180:21: note: (near initialization for ‘librem_ec_driver.class[0]’)
180 | #define THIS_MODULE (&__this_module)
| ^
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
782 | .owner = THIS_MODULE,
| ^~~~~~~~~~~
./include/linux/init.h:180:21: error: initializer element is not computable at load time
180 | #define THIS_MODULE (&__this_module)
| ^
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
782 | .owner = THIS_MODULE,
| ^~~~~~~~~~~
./include/linux/init.h:180:21: note: (near initialization for ‘librem_ec_driver.class[0]’)
180 | #define THIS_MODULE (&__this_module)
| ^
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:782:18: note: in expansion of macro ‘THIS_MODULE’
782 | .owner = THIS_MODULE,
| ^~~~~~~~~~~
/var/lib/dkms/librem_ec_acpi/0.9.2/build/librem_ec_acpi.c:780:46: warning: missing braces around initializer [-Wmissing-braces]
780 | static struct acpi_driver librem_ec_driver = {
|
[ Test case ]
Install the latest linux-6.11 kernel on Noble:
$ sudo add-apt-repository ppa:canonical-kernel-team/ppa
$ sudo apt update
$ sudo apt install linux-image-6.11.0-12-generic \
linux-modules-6.11.0-12-generic \
linux-modules-extra-6.11.0-12-generic \
linux-headers-6.11.0-12-generic
Install librem-ec-acpi-dkms:
$ sudo apt install librem-ec-acpi-dkms
Load the module:
$ sudo modprobe librem-ec-acpi
The same procedure should be repeated on linux-6.8 to test for
possible regressions.
[ Fix ]
Patch the code to properly support the new linux 6.11 ABI.
[ Regression potential ]
A regression is unlikely due to the limited scope of the patch.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/librem-ec-acpi/+bug/2091499/+subscriptions
More information about the Ubuntu-sponsors
mailing list