[Bug 2085370] Re: Important build flag left out of IGC build

[Frank Heimes]

Hi Shane,
I had a look at the modification for noble aka the noble debdiff.

I couldn't debdiff-apply it the patch, got message "Hunk is shorter than expected".
Fortunately the changes are pretty small, so I created one myself and figured out that (somehow) just a trailing blank line was missing ;-)

Just the version that you used "1.0.15468.25-2ubuntu1" is not correct.
Since we are coming from a Debian version "1.0.15468.25-2build1"
and then moving to an Ubuntu specific version, the ubuntu suffix need to start with "ubuntu0.1",
so "1.0.15468.25-2ubuntu0.1" for an SRU.
(according to https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging or
https://github.com/canonical/ubuntu-maintainers-handbook/blob/main/VersionStrings.md - even if lintian
might moan with "changelog-file-missing-explicit-entry 1.0.15468.25-2build1 -> 1.0.15468.25-2ubuntu0 (missing) -> 1.0.15468.25-2ubuntu0.1").
I quickly adjusted the version.

And surprisingly the "update-maintainer" script does not need to be executed,
since d/control already has:
"
Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
XSBC-Original-Maintainer: Debian OpenCL team <pkg-opencl-devel at lists.alioth.debian.org>
"
(but as Debian version I would have expected the XSBC-Original-Maintainer as Maintainer - anyway ...)

I also did a successful PPA test build with -proposed enabled (I know it's a simple change, but one never knows...)
https://launchpad.net/~fheimes/+archive/ubuntu/lp2085370

With that I completed the review and I'm sponsoring and uploading the updated package to the 'noble' queue.
Check the noble queue: https://launchpad.net/ubuntu/noble/+queue?queue_state=1&queue_text=intel-graphics-compiler

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2085370

Title:
  Important build flag left out of IGC build

Status in intel-graphics-compiler package in Ubuntu:
  Fix Released
Status in intel-graphics-compiler source package in Noble:
  In Progress
Status in intel-graphics-compiler source package in Oracular:
  Invalid

Bug description:
  Our partners at Intel have informed us that we are missing a very important build flag for the IGC package:
  -DIGC_OPTION__USE_KHRONOS_SPIRV_TRANSLATOR_IN_SC=1

  Without this build flag enabled, we should expect to see instabilities
  such as pytorch crashes.

  ---------------------- SRU Template ----------------------

  [ Impact ]

   * Users will notice that some software that depends on IGC will be
  less stable

  [ Test Plan ]

   * Intel has done testing on their end and assures us that this is a necessary build flag for their software stack to work as intended.
  * As Pavel has mentioned below, we can check that this is working as intended by running "$ ocloc -device mtl -spirv_input -file ./a.spv"

  [ Where problems could occur ]

  From our contact at Intel:
  "Without the build flag, IGC will not link to translator at all [...] it uses its own internal translator, which is wrong, So this option enables it to link to the distro's translator"

  So while this is a fix, it does carry the inherent risk that we are
  switching to a different translator, which will change the behaviors
  of any software that uses the translator.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/intel-graphics-compiler/+bug/2085370/+subscriptions