[Bug 2062968] Re: mc (Midnight commander) not opening/navigating archives by enter

[Simon Chopin]

Hi Juerg,

While your debdiff is OK for a devel upload (with some improvements
possible ;-) ), SRUs are a slightly different beast, and I've seen
uploads rejected for some of the reasons outlined below.

The first and most important thing is that changes should be as minimal
as possible. Here, that means the 4th patch should be dropped as it is
unrelated to the actual bug and only creates noise.

Second, the version number should probably be 4.8.30-1ubuntu0.1 rather
than ...ubuntu1. While in this particular case it wouldn't be a problem
since Oracular shipped with a new version, it's a good habit to take.

Third, the patches could use some DEP-3 love: https://dep-team.pages.debian.net/deps/dep3/
I find the Origin, Forwarded and Applied-Upstream particularly helpful for ongoing maintenance.

And finally, the changelog could maybe be a bit verbose?

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2062968

Title:
  mc (Midnight commander) not opening/navigating archives by enter

Status in Midnight Commander:
  Fix Released
Status in mc package in Ubuntu:
  Fix Released
Status in mc source package in Noble:
  Confirmed

Bug description:
  [ Impact ]

  In ubuntu 24.04 mc (Midnight commander) not opening/navigating
  archives by enter.

  Probably need update to 4.8.31 version according to this post:
  https://github.com/orgs/Homebrew/discussions/3467#discussioncomment-8265535

  ProblemType: Bug
  DistroRelease: Ubuntu 24.04
  Package: mc 3:4.8.30-1build2
  ProcVersionSignature: Ubuntu 6.8.0-28.28-generic 6.8.1
  Uname: Linux 6.8.0-28-generic x86_64
  ApportVersion: 2.28.1-0ubuntu2
  Architecture: amd64
  CasperMD5CheckResult: pass
  CurrentDesktop: ubuntu:GNOME
  Date: Sat Apr 20 16:38:56 2024
  InstallationDate: Installed on 2024-04-19 (1 days ago)
  InstallationMedia: Ubuntu 24.04 LTS "Noble Numbat" - Beta amd64 (20240418)
  ProcEnviron:
   LANG=ru_RU.UTF-8
   PATH=(custom, no user)
   SHELL=/bin/bash
   TERM=xterm-256color
   XDG_RUNTIME_DIR=<set>
  SourcePackage: mc
  UpgradeStatus: No upgrade log present (probably fresh install)

  [ Test Plan ]

  Navigate to an archive, press ENTER, verify archive is opened and
  content is displayed properly.

  [ Where Problems Could Occur ]

  The patch modifies the config file mc.ext.in so theoretically other
  config settings might get messed up, if the patch is incorrect.

  [ Other Info ]

  Patch is pulled from here:
  https://salsa.debian.org/debian/mc/-/commit/daeabd910de6868140272e365f755d207a986e39

To manage notifications about this bug go to:
https://bugs.launchpad.net/mc/+bug/2062968/+subscriptions