[Bug 1703307] Re: [SRU] Unable to rename tabs

[Brian Murray]

Unsubscribing sponsors since there is nothing left to sponsor.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1703307

Title:
  [SRU] Unable to rename tabs

Status in lxterminal package in Ubuntu:
  Fix Released
Status in lxterminal source package in Zesty:
  Fix Committed
Status in lxterminal source package in Artful:
  Fix Released
Status in lxterminal package in Debian:
  Fix Released

Bug description:
  [Original Description]

  The current lxterminal 0.3.0 has a bug that cannot rename tabs, which is
  fixed in an upstream commit:

  https://git.lxde.org/gitweb/?p=lxde/lxterminal.git;a=commit;h=e2ad448556ee0f78ebdd0e36dc16e96702326fb6

  [Impact]

  Without this fix, users are unable to rename a tab in LXTerminal by
  pressing Ctrl + Shift + I, as the OK and Close buttons are not
  present. This is a regression from the previous version, and should be
  fixed.

  [Test Case]

   1. Open LXTerminal.
   2. Press Ctrl + Shift + I

  Expected result:
   The user should be able to specify their own name for the tab, and either press Enter/Return on their keyboard or an OK button on the dialog box.

  Actual result:
   A dialog box is present allowing the user to change the text, but there are no OK or Close buttons present, and when the user presses Enter/Return on their keyboard, it does nothing.

  [Regression Potential]

  The potential for a regression to occur is unlikely, as the fix is
  simply defining strings for buttons:

  -        NULL, GTK_RESPONSE_CANCEL,
  -        NULL, GTK_RESPONSE_OK,
  +        _("_Cancel"), GTK_RESPONSE_CANCEL,
  +        _("_OK"), GTK_RESPONSE_OK,

  If the underlying GTK libraries change (which is, to be fair,
  extremely unlikely given that this is a stable release), it could
  maybe cause a regression, but it wouldn't be limited to lxterminal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxterminal/+bug/1703307/+subscriptions