[Bug 1703307] Re: [SRU] Unable to rename tabs

[Brian Murray]

Hello Simon, or anyone else affected,

Accepted lxterminal into zesty-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/lxterminal/0.3.0-1ubuntu0.2 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-zesty to verification-done-zesty. If it does not fix
the bug for you, please add a comment stating that, and change the tag
to verification-failed-zesty. In either case, details of your testing
will help us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: lxterminal (Ubuntu Zesty)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-zesty

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1703307

Title:
  [SRU] Unable to rename tabs

Status in lxterminal package in Ubuntu:
  Fix Released
Status in lxterminal source package in Zesty:
  Fix Committed
Status in lxterminal source package in Artful:
  Fix Released
Status in lxterminal package in Debian:
  Fix Released

Bug description:
  [Original Description]

  The current lxterminal 0.3.0 has a bug that cannot rename tabs, which is
  fixed in an upstream commit:

  https://git.lxde.org/gitweb/?p=lxde/lxterminal.git;a=commit;h=e2ad448556ee0f78ebdd0e36dc16e96702326fb6

  [Impact]

  Without this fix, users are unable to rename a tab in LXTerminal by
  pressing Ctrl + Shift + I, as the OK and Close buttons are not
  present. This is a regression from the previous version, and should be
  fixed.

  [Test Case]

   1. Open LXTerminal.
   2. Press Ctrl + Shift + I

  Expected result:
   The user should be able to specify their own name for the tab, and either press Enter/Return on their keyboard or an OK button on the dialog box.

  Actual result:
   A dialog box is present allowing the user to change the text, but there are no OK or Close buttons present, and when the user presses Enter/Return on their keyboard, it does nothing.

  [Regression Potential]

  The potential for a regression to occur is unlikely, as the fix is
  simply defining strings for buttons:

  -        NULL, GTK_RESPONSE_CANCEL,
  -        NULL, GTK_RESPONSE_OK,
  +        _("_Cancel"), GTK_RESPONSE_CANCEL,
  +        _("_OK"), GTK_RESPONSE_OK,

  If the underlying GTK libraries change (which is, to be fair,
  extremely unlikely given that this is a stable release), it could
  maybe cause a regression, but it wouldn't be limited to lxterminal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxterminal/+bug/1703307/+subscriptions