[Merge] lp:~evfool/synaptic/ancientfixes into lp:synaptic

[Daniel Hartwig]

Please reconsider this change:

  * Hide the only download packages checkbox if there are no files
    to download (LP: #413453)

because it may still be enabled from a previous run (see ::showAndConfirm).  The check for “download size is nil” is too simple.  You also do *not* want to automagically unset this some times and not others, this is very disruptive behaviour.

To keep things simple, I suggest to revert this change and close the associated bug.

=== modified file 'gtk/rgsummarywindow.cc'
--- gtk/rgsummarywindow.cc	2010-10-07 19:51:48 +0000
+++ gtk/rgsummarywindow.cc	2012-04-10 17:44:21 +0000
@@ -393,6 +393,7 @@
 		      toDowngrade, unAuthenticated,sizeChange);
    lister->getDownloadSummary(dlCount, dlSize);
 
+   gtk_widget_set_visible(_dlonlyB, (dlSize > 0));
 #if 0
    if (held) {
       char *str = ngettext("%d package is locked\n",

-- 
https://code.launchpad.net/~evfool/synaptic/ancientfixes/+merge/93134
Your team Ubuntu Sponsors Team is requested to review the proposed merge of lp:~evfool/synaptic/ancientfixes into lp:synaptic.