[Bug 1850672] Re: "precise esm -> trusty -> trusty new client" upgrade disables ESM

[Andreas Hasenack]

** Description changed:

  [Impact]
  When enabling ESM on precise, then upgrading that to current trusty, and from there to the proposed new trusty client (see #1832757), ESM gets disabled.
  
  This was found when executing test case (5) in the original SRU bug
  #1832757.
  
  The reason is that d/postinst, when dealing with this upgrade path, was
  conditioning a file rename on the package upgrade coming from version 1,
  which is the precise one. The fix is to drop that conditional, since the
  filename we intend to rename is the precise one (it has "precise" in its
  name) and there is no need to check for the version.
  
  [Test Case]
  
  lxc launch ubuntu-daily:precise p1
- lxc exec p1 ubuntu-advantage enable-esm $USER:$PASS
+  lxc exec p1 ubuntu-advantage enable-esm $USER:$PASS
+ # confirm esm is enabled and working by downloading a package
+ lxc exec p1 -- apt-get install -d python-jinja2
+ lxc exec p1 apt-get clean
  lxc exec p1 do-release-upgrade
  lxc exec p1 -- bash -c "echo deb http://archive.ubuntu.com/ubuntu trusty-proposed main > /etc/apt/sources.list.d/trusty-proposed.list"
  lxc exec p1 apt-get update
  lxc exec p1  -- apt-get install -y ubuntu-advantage-tools
  lxc exec p1 apt-get update
  lxc exec p1 apt-cache policy|grep esm
  # try to download a trusty esm package, it should work
  lxc exec p1 -- apt-get install -d python-jinja2
- 
+ lxc exec p1 apt-get clean
  
  [Regression Potential]
  Before we were pinning this upgrade path on having come from the exact precise package version, which is "1". Now we are dropping that requirement, and only checking if the precise esm sources.list file exists, then we rename it to the trusty name:
  
  ubuntu-esm-precise.list -> ubuntu-esm-infra-trusty.list
  
  do-release-upgrade will have renamed "precise" to "trusty" inside
  ubuntu-esm-precise.list. If someone is doing the upgrade manually via
  dist-upgrade, for example, then this person is expected to rename the
  precise repositories to trusty ones in all of /etc/apt/sources.list*
  
  [Other Info]
  As with the $1832757 SRU, this is being published only on trusty.

** Description changed:

  [Impact]
  When enabling ESM on precise, then upgrading that to current trusty, and from there to the proposed new trusty client (see #1832757), ESM gets disabled.
  
  This was found when executing test case (5) in the original SRU bug
  #1832757.
  
  The reason is that d/postinst, when dealing with this upgrade path, was
  conditioning a file rename on the package upgrade coming from version 1,
  which is the precise one. The fix is to drop that conditional, since the
  filename we intend to rename is the precise one (it has "precise" in its
  name) and there is no need to check for the version.
  
  [Test Case]
  
  lxc launch ubuntu-daily:precise p1
-  lxc exec p1 ubuntu-advantage enable-esm $USER:$PASS
+  lxc exec p1 ubuntu-advantage enable-esm $USER:$PASS
  # confirm esm is enabled and working by downloading a package
  lxc exec p1 -- apt-get install -d python-jinja2
  lxc exec p1 apt-get clean
- lxc exec p1 do-release-upgrade
+ # ssh into p1 and call do-release-upgrade (doesn't work via lxc exec)
+ ssh p1
+     sudo do-release-upgrade
+     logout
  lxc exec p1 -- bash -c "echo deb http://archive.ubuntu.com/ubuntu trusty-proposed main > /etc/apt/sources.list.d/trusty-proposed.list"
  lxc exec p1 apt-get update
  lxc exec p1  -- apt-get install -y ubuntu-advantage-tools
  lxc exec p1 apt-get update
  lxc exec p1 apt-cache policy|grep esm
  # try to download a trusty esm package, it should work
  lxc exec p1 -- apt-get install -d python-jinja2
  lxc exec p1 apt-get clean
  
  [Regression Potential]
  Before we were pinning this upgrade path on having come from the exact precise package version, which is "1". Now we are dropping that requirement, and only checking if the precise esm sources.list file exists, then we rename it to the trusty name:
  
  ubuntu-esm-precise.list -> ubuntu-esm-infra-trusty.list
  
  do-release-upgrade will have renamed "precise" to "trusty" inside
  ubuntu-esm-precise.list. If someone is doing the upgrade manually via
  dist-upgrade, for example, then this person is expected to rename the
  precise repositories to trusty ones in all of /etc/apt/sources.list*
  
  [Other Info]
  As with the $1832757 SRU, this is being published only on trusty.

-- 
You received this bug notification because you are a member of Ubuntu
Server, which is subscribed to ubuntu-advantage-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1850672

Title:
  "precise esm -> trusty -> trusty new client" upgrade disables ESM

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-advantage-script/+bug/1850672/+subscriptions