[Bug 427612] Re: does not pass pressed caps lock to client

Paolo Bonzini bonzini at gnu.org
Fri Feb 12 19:48:54 GMT 2010


The sdl patch was correctly submitted as

+    SDL_UseLockKeys = getenv ("SDL_DISABLE_LOCK_KEYS") == NULL;

...

+    use_lock_keys = SDL_UseLockKeys;

...

+                if (!use_lock_keys)
+                    break;

(i.e. by default do not change anything) but the maintainer apparently
morphed it into

+    SDL_UseLockKeys = getenv("SDL_DISABLE_LOCK_KEYS");

...

+     use_lock_keys = ( SDL_UseLockKeys && *SDL_UseLockKeys );

...

+                 if ( ! use_lock_keys )
+                     break;

which changed the meaning of SDL_DISABLE_LOCK_KEYS and, at the same
time, the default.  A better patch to qemu would be to stick

    putenv ("SDL_DISABLE_LOCK_KEYS", "howlame");

before SDL_Init.  Also totally inacceptable by upstream, but at least it
doesn't break Debian/Ubuntu qemu if the wrong 205_lock_keys.patch is
removed from libsdl.

-- 
does not pass pressed caps lock to client
https://bugs.launchpad.net/bugs/427612
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to qemu-kvm in ubuntu.



More information about the Ubuntu-server-bugs mailing list